[BUGFIX] Fix comment parsing to support multiple comments (backported)#671
Conversation
…s#671) Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes MyIntervals#173 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
support-multiple-comments-backported
branch
from
2b15ee9 to
6ccfb21
Compare
|
I'm a bit confused … do I need to forward-port this, or is this not necessary due to other upcoming changes in (In general, if we want to create a PR that we are also planning to backport, we first create the PR for |
|
I've now forward-ported this in #672. For future patches, please let's create the change for |
|
I wasn't done with the patches. As the solution for v8.x looks very different from the proposed solution for v9.0, I was about to create different patches. Either back-porting or forward-porting would have meant a completely different approach. |
|
All right. I’m looking forward to your PRs! 🙏 |
|
And if you think talking things through would be helpful, please feel free to chat me up. |
2 participants
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule.
Fixes #173